fix: bug when using mise use -g when MISE_ENV is filled #4494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think anytime we modify this code we should add a test. I don't think this would regress again, but this code has also been shown to be the result of so many bugs. |
|
Agree. Will look into adding some e2e tests later today or tomorrow. |
jdx
pushed a commit
that referenced
this pull request
Feb 25, 2025
### 🚀 Features - **(registry)** add checkmake to registry by [@eread](https://github.com/eread) in [#4466](#4466) - **(registry)** added sops from aqua registry by [@ldrouard](https://github.com/ldrouard) in [#4457](#4457) - **(registry)** added k9s from aqua registry by [@ldrouard](https://github.com/ldrouard) in [#4460](#4460) - **(registry)** added hadolint from aqua registry by [@ldrouard](https://github.com/ldrouard) in [#4456](#4456) - **(shim)** Windows shim add hardlink & symlink mode by [@qianlongzt](https://github.com/qianlongzt) in [#4409](#4409) - **(ubi)** add option `rename_exe` by [@wlmitch](https://github.com/wlmitch) in [#4512](#4512) - use aqua for hk by [@jdx](https://github.com/jdx) in [f68de38](f68de38) - add bazel-watcher to registry by [@betaboon](https://github.com/betaboon) in [#4296](#4296) ### 🐛 Bug Fixes - behavior of .disable-self-update by [@ZeroAurora](https://github.com/ZeroAurora) in [#4476](#4476) - devcontainer by [@acesyde](https://github.com/acesyde) in [#4483](#4483) - mise outdated --json does not return json if all tools are up-to-date by [@roele](https://github.com/roele) in [#4493](#4493) - bug when using mise use -g when MISE_ENV is filled by [@roele](https://github.com/roele) in [#4494](#4494) - config of symlink tracked on windows is not respected by [@NavyD](https://github.com/NavyD) in [#4501](#4501) - pruning unused tool leaves broken symlinks by [@roele](https://github.com/roele) in [#4507](#4507) ### 📚 Documentation - Fixes typo in lang/zig by [@carldaws](https://github.com/carldaws) in [#4497](#4497) - Fix activation on PowerShell by [@kit494way](https://github.com/kit494way) in [#4498](#4498) ### Chore - remove aur job by [@jdx](https://github.com/jdx) in [fe5a71d](fe5a71d) - remove reference to aur in release script by [@jdx](https://github.com/jdx) in [0824490](0824490) - deny ring sec by [@jdx](https://github.com/jdx) in [08e334c](08e334c) ### New Contributors - @betaboon made their first contribution in [#4296](#4296) - @ldrouard made their first contribution in [#4456](#4456) - @qianlongzt made their first contribution in [#4409](#4409) - @wlmitch made their first contribution in [#4512](#4512) - @carldaws made their first contribution in [#4497](#4497) - @ZeroAurora made their first contribution in [#4476](#4476)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4490
Using
MISE_ENVcircumvents the option overrides, soglobal,pathandenvoptions should come beforeMISE_ENVin the loading priority.