.disable-self-update not working

[ZeroAurora]

Related #4077
I was packaging mise for a distribution (AOSC OS, in case that you're interested) whose style guide requires disabling self update feature. I discovered that the logic of disabling self-update was not correct.

mise/src/cli/self_update.rs

Lines 115 to 122 in fe5a71d

	pub fn is_available() -> bool {
	!std::fs::canonicalize(&*env::MISE_BIN)
	.ok()
	.and_then(|p| p.parent().map(|p| p.to_path_buf()))
	.and_then(|p| p.parent().map(|p| p.to_path_buf()))
	.map(|p| p.join("lib").join(".disable-self-update").exists())
	.unwrap_or_default()
	}

Suppose mise is located at /usr/bin/mise, the function will look at /usr/lib/.disable-self-update rather than /usr/lib/mise/.disable-self-update. This is a problem that affects almost every distribution's packaging.

mise doctor (I believe it's not needed)

version: 2025.2.6 linux-x64 (2025-02-20)
activated: yes
shims_on_path: no

build_info:
  Target: x86_64-unknown-linux-gnu
  Features: DEFAULT, NATIVE_TLS, SELF_UPDATE
  Built: Thu, 20 Feb 2025 07:37:51 +0000
  Rust Version: rustc 1.84.1 (e71f9a9a9 2025-01-27) (built from a source tarball)
  Profile: release

shell:
  /bin/fish
  fish, version 3.7.1

dirs:
  cache: ~/.cache/mise
  config: ~/.config/mise
  data: ~/.local/share/mise
  shims: ~/.local/share/mise/shims
  state: ~/.local/state/mise

config_files:
  ~/.config/mise/config.toml

ignored_config_files: (none)

backends:
  aqua
  asdf
  cargo
  core
  dotnet
  gem
  go
  npm
  pipx
  spm
  ubi
  vfox

plugins:
  julia  https://github.com/mise-plugins/mise-julia.git#52222ed

toolset:
  asdf:julia@1.11.2
  core:rust@1.84.0
  ubi:jdx/usage@2.0.3

path:
  ~/.local/share/mise/installs/julia/1.11.2/bin
  ~/.cargo/bin
  ~/.local/share/mise/installs/usage/2.0.3
  /usr/local/sbin
  /usr/local/bin
  /usr/sbin
  /usr/bin
  /sbin
  /bin
  /usr/games
  /usr/local/games
  /usr/lib/wsl/lib
  ~/.local/bin
  ~/bin
  /mnt/c/Users/ZeroAurora/AppData/Local/Programs/Microsoft VS Code/bin/
  ~/.local/bin
  ~/bin
  /mnt/c/Users/ZeroAurora/AppData/Local/Programs/Microsoft VS Code/bin/

env_vars:
  MISE_SHELL=fish

settings:
mise WARN  mise version 2025.2.7 available
mise WARN  To update, run mise self-update

1 problem found:

1. new mise version 2025.2.7 available, currently on 2025.2.6

[ZeroAurora]

I implemented a quick fix in #4476 .

Personally, I would like to put forward the following points:

• I noticed that this function has lots of clones. Maybe we can convert it to references?

    pub fn is_available() -> bool {
        !std::fs::canonicalize(&*env::MISE_BIN)
            .ok()
            .as_ref()
            .and_then(|p| p.parent())
            .and_then(|p| p.parent())
            .map(|p| {
                p.join("lib")
                    .join("mise")
                    .join(".disable-self-update")
                    .exists()
            })
            .unwrap_or_default()
    }

• The best solution of this issue will be conditional compiling via cargo features, but it will break existing packaging.

Never mind if you are not interested :) A quick ping at @jdx to look at it

[ZeroAurora]

solved in #4476