Fix keep docs dir #89
Merged
+333
−291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version Number CheckUpdate the version in pyproject.toml if you want this PR to generate a new release (main is 0.6.0 >= 0.6.0). |
Previously this value didn't matter, only the setting on each import had an effect. Now we use the global value (False by default) unless a repo overrides the value with either True or False.
Now we test all possible combinations of settings instead
Sebastian-0
force-pushed
the
fix-keep-docs-dir
branch
from
1a8fd0c to
ae31df9
Compare
|
@Sebastian-0, I can handle the rest. Thanks for contributing and improving the plugin. I appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will change the behaviour of
keep_docs_dirforDocsRepoas follows:keep_docs_dir:True,FalseandNone.Nonethe global setting is used instead, this is now the defaultTrueorFalseit will override the global settingPreviously
keep_docs_dirwas always false and the global setting was always ignored (regardless of whether or notkeep_docs_dirwas true or false).I also added
parameterizedas a test dependency so that I could parameterizetest_keep_docs_dirand test all permutations of local vs. globalkeep_docs_dirvalues.