Add 'take', 'replace', 'replace_with' from std::cell::RefCell #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changeset also clarifies the language around mutable borrows. The
message accountable_refcell paniced with when trying to take a mutable
borrow was not entirely accurate ("RefCell is already immutably borrowed"),
as panics can also occur when trying to mutably borrow a RefCell that is
already mutably borrowed.
Technically, at the time of this writing, the `take` method is not in
stable Rust, but will be in the next version (1.49) rust-lang/rust#71395
A rust-toolchain file has been added codifying the expectation that this
crate targets stable Rust.
|
Looks great! Thanks for adding these! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
take,replace, andreplace_withfrom std::cell::RefCellThis PR also clarifies the language around mutable borrows. The message
accountable_refcellcurrently panics with when trying to take a mutable borrow is not entirely accurate ("RefCell is already immutably borrowed"), as panics can also occur when trying to mutably borrow a RefCell that is already mutably borrowed.Technically, at the time of this writing, the
takemethod is not in stable Rust but will be in the next version (1.49) rust-lang/rust#71395. Is it OK to add it now, or would you prefer to wait on this?