Fix previous/next page icon on win32 #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefer the use of `go-previous-symbolic` and `go-next-symbolic` icons over `media-seek-backward` and `media-seek-forward`, as the former icons are available in GTK's default icon theme: https://gitlab.gnome.org/GNOME/gtk/-/tree/4.13.2/gtk/icons/scalable/actions This would avoid having to depend on the Adwaita icon theme. See: https://gitlab.gnome.org/GNOME/gtk/-/issues/3794
kleisauke
added a commit
to libvips/build-win64-mxe
that referenced
this pull request
Oct 27, 2023
|
Oh, nice! Although the default icon theme is terrible and we should include something better, as well as this patch, of course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer the use of
go-previous-symbolicandgo-next-symbolicicons overmedia-seek-backwardandmedia-seek-forward, as the former icons are available in GTK's default icon theme: https://gitlab.gnome.org/GNOME/gtk/-/tree/4.13.2/gtk/icons/scalable/actionsThis would avoid having to depend on the Adwaita icon theme.
See: https://gitlab.gnome.org/GNOME/gtk/-/issues/3794