Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix repeat to create casbin_sequence for PostgreSQL #60

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

OutOfEastGate
Copy link
Collaborator

fix: #59

@casbin-bot
Copy link

@tangyang9464 @imp2002 please review

Copy link
Member

@imp2002 imp2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsluoyz hsluoyz changed the title fix: fix repeat to create casbin_sequence for PostgreSQL feat: fix repeat to create casbin_sequence for PostgreSQL Nov 14, 2022
@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Base: 73.33% // Head: 73.33% // No change to project coverage 👍

Coverage data is based on head (170d7ce) compared to base (ab66263).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #60   +/-   ##
=======================================
  Coverage   73.33%   73.33%           
=======================================
  Files           3        3           
  Lines          90       90           
  Branches       26       26           
=======================================
  Hits           66       66           
  Misses         13       13           
  Partials       11       11           
Impacted Files Coverage Δ
.../main/java/org/casbin/adapter/JDBCBaseAdapter.java 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hsluoyz hsluoyz merged commit c0435fe into jcasbin:master Nov 14, 2022
@github-actions
Copy link

🎉 This PR is included in version 2.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

casbin_sequence is generated even when casbin_rule table is made beforehand using GenerationType.IDENTITY
4 participants