casbin_sequence is generated even when casbin_rule table is made beforehand using GenerationType.IDENTITY

[offset-null1]

I implicitly created casbin_rule table with Id generation type as IDENTITY. But it created casbin_sequence which wasn't required and happened because of
case "PostgreSQL": sql = renderActualSql("CREATE SEQUENCE IF NOT EXISTS CASBIN_SEQUENCE START 1;");

in JDBCBaseAdapter.java .
It should only be executed when the table doesn't exist otherwise the generation of sequence is redundant.

[casbin-bot]

@tangyang9464 @imp2002

[hsluoyz]

@OutOfEastGate

[OutOfEastGate]

@offset-null1 Thank you for your feedback. I will deal with it soon.

[hsluoyz]

@offset-null1 are you a user or contributor?

[offset-null1]

@hsluoyz I'm using this module to contribute to this issue.

[offset-null1]

Yes, that prevents the creation of `casbin_sequence` but as the default is true, I feel before generating the sequence there should be a check if the table exists or not. In my case I didn't set it to false but had a table already created, still the sequence was generated i.e., I ended up having 2 sequences in the database.

[OutOfEastGate]

Yes, that prevents the creation of casbin_sequence but as the default is true, I feel before generating the sequence there should be a check if the table exists or not. In my case I didn't set it to false but had a table already created, still the sequence was generated i.e., I ended up having 2 sequences in the database.

I know what you mean.By default, we create casbin_sequence. If you have your own requirements, you can modify the parameters of casbin_sequence directly.In mybatis adapter, sequence is not created by default. Of course, we will refine this section to check the existence of the table before creating the casbin_sequence.

[offset-null1]

Okay, thank you for the clarification.

[github-actions]

🎉 This issue has been resolved in version 2.4.0 🎉

The release is available on:

• GitHub release
• v2.4.0

Your semantic-release bot 📦🚀