Skip to content

TopologyGenerators.generateRing() does not position the nodes correctly #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
acasteigts opened this issue Nov 3, 2021 · 3 comments
Open

TopologyGenerators.generateRing() does not position the nodes correctly #111

acasteigts opened this issue Nov 3, 2021 · 3 comments
Assignees
@acasteigts @remikey
Labels
bug ready This issue is fixed. It awaits to be released.
Milestone
next

Comments

@acasteigts
Copy link
Member

When creating nodes with TopologyGenerators.generateRing(), the nodes are not well placed correctly, as witnessed by the attached picture.
ring
@acasteigts acasteigts added the bug label Nov 3, 2021
@remikey remikey self-assigned this Nov 4, 2021
@remikey remikey added this to the next milestone Nov 4, 2021
remikey added a commit that referenced this issue Nov 4, 2021
@remikey
Fix: #111 - TopologyGenerators.generateRing() and TopologyGenerator.g…
2211667 
…enerateKN() now take the topology into account
remikey added a commit that referenced this issue Nov 4, 2021
@remikey
Chg: #111 - update Changelog
5cb22ad
remikey added a commit that referenced this issue Nov 4, 2021
@remikey
Chg: #111 - update Changelog
38e111c
@remikey
Copy link
Member

remikey commented Nov 4, 2021

Cause of the problem: TopologyGenerators.generateRing() had incoherent positioning and dimensioning values.

Fix: A new method, which centers the shape in the Topology and sizes it to secure a margin.
Bonus: for consistency sake, TopologyGenerators.generateKN() now also uses that method.

@remikey
Copy link
Member

remikey commented Nov 4, 2021

@acasteigts , please have a look at branch fix/111-topologygenerators-generateRing-positioning.

Note: It is not based on develop, but on the branch which fixes #108 .

@remikey
Copy link
Member

remikey commented Nov 15, 2021

merged into develop.

@remikey remikey added the ready This issue is fixed. It awaits to be released. label Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acasteigts acasteigts

@remikey remikey

Labels
bug ready This issue is fixed. It awaits to be released.
Projects
None yet
Milestone
next
Development

No branches or pull requests
2 participants
@acasteigts @remikey