Skip to content

Commit

Permalink
💚 check for changes found by moban
Browse files Browse the repository at this point in the history
Re-instates check dropped in b8b61f8.

Use --ignore-blank-lines because sphinx templates have
trailing lines that are not wanted here, and 92b799a
and others removed the custom handling of these, and
moban doesnt yet have post-processors to handle this.

git diff --ignore-blank-lines --exit-code still emits
an exit code even if there was no applicable changes,
even with git v2.22.0 on Travis' bionic image.
Workaround with a shell loop.
  • Loading branch information
jayvdb committed Jul 9, 2019
1 parent 78b672f commit e157e88
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ all: upstreaming

upstreaming:
moban -m mobanfile
git diff
git diff --ignore-blank-lines | while read line; do if [ "$line" ]; then exit 1; fi; done

lint: flake8 . --exclude=.moban.d,docs --builtins=unicode,xrange,long

Expand Down

0 comments on commit e157e88

Please sign in to comment.