-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/flexible release #19
Feature/flexible release #19
Conversation
this changes allows for user input to the action to specify the os arch and os platform as an override. it also updates the matching pattern to match more flexible naming.
Hi @jaxxstorm please let me know if this is something to consider merging or any feedback is welcome. I reviewed the |
@phillipjf this looks awesome, thanks so much! I'll discuss with the team using it at Pulumi, this looks to be a breaking change to want to make sure we release appropriately. |
@phillipjf would you mind adding some tests/integration tests for your changes? |
@jaxxstorm thanks for the reply. I'll take a look at getting some tests added. Is there a preference for framework/etc. within the org? There aren't any existing tests to base off of. I also tried to make this change pretty backwards-compatible, so if you see anything breaking, I'm willing to update to accommodate. |
sorry I think I was unclear, all I need is an example download in here: https://github.com/jaxxstorm/action-install-gh-release/blob/master/.github/workflows/test.yml You've already got some examples in the readme, just add those to the workflow :) |
@jaxxstorm thanks for the clarification. I pushed up an additional suite of jobs to test the changes I made. Looks like it needs approval to run. edit: actually -- glossed over using the |
@jaxxstorm I revised the test action. I'll review the results once it's approved to run. You can cancel the previous run. |
pushed a fix for the action..typo in the |
I added
Based on the last run, everything looks as expected. |
Awesome! thanks for the amazing contribution |
@jaxxstorm when you have a chance, can you create a tag/release for this? |
This PR adds functionality to support: