[better_errors] Port the Pallas debug info mechanisms to the new JAX debugging info #26058
+121
−196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnecula
force-pushed
the
debug_info_pallas
branch
2 times, most recently
from
8c59a92 to
f69e723
Compare
gnecula
force-pushed
the
debug_info_pallas
branch
5 times, most recently
from
2531ab5 to
62a3f61
Compare
gnecula
force-pushed
the
debug_info_pallas
branch
from
62a3f61 to
072c3e2
Compare
gnecula
force-pushed
the
debug_info_pallas
branch
2 times, most recently
from
ae4f48f to
4e908f2
Compare
gnecula
force-pushed
the
debug_info_pallas
branch
from
4e908f2 to
7d767ca
Compare
superbobry
approved these changes
Feb 21, 2025
gnecula
force-pushed
the
debug_info_pallas
branch
9 times, most recently
from
18d6b54 to
a5e0451
Compare
…DebugInfo. Now that we carry debug informatiion in Jaxpr we can remove the Pallas-specific tracking of the `func_src_info`, e.g., `NameAndSrcInfo`.
gnecula
force-pushed
the
debug_info_pallas
branch
from
a5e0451 to
c4e0db6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we carry debug informatiion in Jaxpr we can remove the Pallas-specific tracking of debugging info. We remove
NameAndSrcInfoand its usage.