Add missing super().__init__() involving types wrapped in xla/python/sharding.cc
#19582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_602787434
branch
4 times, most recently
from
7a46d39 to
ed65455
Compare
…n/sharding.cc This change is to unblock google/pybind11clif#30095. Leaving wrapped C++ types uninitialized creates a potential for triggering undefined behavior from Python. PiperOrigin-RevId: 602884828
copybara-service
bot
force-pushed
the
test_602787434
branch
from
ed65455 to
4f5e71c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing
super().__init__()involving types wrapped in xla/python/sharding.ccThis change is to unblock google/pybind11clif#30095.
Leaving wrapped C++ types uninitialized creates a potential for triggering undefined behavior from Python.