fix external monitor bugs, mainly by calling CGDisplayCreateImage without passing the display frame #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hout passing the display frame
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not perfect, but if fixes #55.
It also allows viewing timeline on other monitors and maintains aspect ratio, and allows recording with multiple monitors.
I won't go so far as to say we support multiple monitors yet - but maybe i'll say we are "alpha".
It's ugly, but it "works". It definitely can be done much better.
A better approach might be, if the display changes, start a new video at that resolution.
We either need to integrate automatic scaling into ffmpeg, or handle it how i'm currently doing in this PR.
But I believe this unblocks a lot of users, so I want to get it in.