Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add .nmvrc check and arg-less nvs add #138

Merged
merged 4 commits into from
Aug 16, 2019
Merged

feat: add .nmvrc check and arg-less nvs add #138

merged 4 commits into from
Aug 16, 2019

Conversation

RichiCoder1
Copy link
Contributor

@RichiCoder1 RichiCoder1 commented Aug 16, 2019

It looks like you already did a ton of good work in NodeVersion to ensure nvm compatibility, so it was just a matter of checking for the presence of an .nvmrc and attempting to use that version.

Let me know if you think this is good and I'll add test/docs.

Closes #113;

@jasongin
Copy link
Owner

jasongin commented Aug 16, 2019

Looks good. Tests and docs would be nice too!

I have one concern: nvs does not support 100% of the same version syntax as nvm. The one major difference I'm aware of is how with nvm you can specify lts/* (for latest lts) or lts/carbon (for latest node 8.x).

Edit: Wait, now that I checked the code I see I did code that compatibility already. Nevermind!

@RichiCoder1
Copy link
Contributor Author

Edit: Wait, now that I checked the code I see I did code that compatibility already. Nevermind!

Yup! It looks like you already cover pretty much every readonable .nvmrc case :).

I'll add some docs and tests in the morn!

@RichiCoder1
Copy link
Contributor Author

Added a light test and some docs & comment updates

Verified

This commit was signed with the committer’s verified signature.
RichiCoder1 Richard Simpson
Copy link
Owner

@jasongin jasongin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with just those small doc edits.

Thanks!

@jasongin jasongin merged commit 58196ca into jasongin:master Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read version from .nvmrc
2 participants