-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add .nmvrc check and arg-less nvs add
#138
Conversation
Looks good. Tests and docs would be nice too!
Edit: Wait, now that I checked the code I see I did code that compatibility already. Nevermind! |
Yup! It looks like you already cover pretty much every readonable .nvmrc case :). I'll add some docs and tests in the morn! |
Added a light test and some docs & comment updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, with just those small doc edits.
Thanks!
It looks like you already did a ton of good work in
NodeVersion
to ensurenvm
compatibility, so it was just a matter of checking for the presence of an.nvmrc
and attempting to use that version.Let me know if you think this is good and I'll add test/docs.
Closes #113;