Fixing CI #2857
Merged
Fixing CI #2857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npx rollup@latest produces Rollup version 2 nowadays, which is incompatible with Node.js <10.
jgonggrijp
added a commit
to jgonggrijp/underscore
that referenced
this pull request
Aug 1, 2020
jgonggrijp
added a commit
that referenced
this pull request
Sep 25, 2020
jgonggrijp
added a commit
that referenced
this pull request
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a side branch with several experimental commits aiming to fix #2847. I succeeded in the end, so we'll have working CI checks again after I merge this.
The Travis build matrix now covers Node.js versions 8, 10 and 14. I'm skipping version 12 in order to reduce our carbon footprint, on the assumption that if 10 and 14 both work, 12 will probably work as well. If this turns out to be problematic, people are welcome to submit an issue or pull request.
The Sauce Labs integration doesn't work yet due to missing configuration. I consider this a separate issue.