Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: use Object.prototype for correct usage of hasOwnProperty #1304

Conversation

nolliebigspin
Copy link
Contributor

@nolliebigspin nolliebigspin commented Feb 6, 2025

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...
fixes #1303

@nolliebigspin nolliebigspin changed the title fix(#1303): use Object.prototype for correct usage of hasOwnProperty Bugfix: use Object.prototype for correct usage of hasOwnProperty Feb 6, 2025
@nolliebigspin nolliebigspin force-pushed the bugfix/handle-null-created-objects-in-serialize branch from ccb2a04 to 64e1a89 Compare February 7, 2025 05:35
@jaredwray
Copy link
Owner

@nolliebigspin - thanks for doing this and we will get this fix out in the next week or so.

@jaredwray jaredwray merged commit b0b572a into jaredwray:main Feb 8, 2025
5 checks passed
@drodil
Copy link
Contributor

drodil commented Feb 18, 2025

Good finding and fix @nolliebigspin! This same bug was in the json-buffer dependency before it was replaced with own serialization (https://github.com/dominictarr/json-buffer/blob/master/index.js#L22)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: data.hasOwnProperty is not a function
3 participants