New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle errors in store.set method and return result status #1245

Merged

jaredwray merged 5 commits into jaredwray:main from Sadzurami:fix-keyv-set-result

Dec 11, 2024

Contributor

Sadzurami commented Dec 11, 2024 •

edited by jaredwray

Loading

Please check if the PR fulfills these requirements

Followed the Contributing guidelines.
Tests for the changes have been added (for bug fixes/features) with 100% code coverage.
Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

ref: #1244

Sadzurami and others added 5 commits

December 11, 2024 15:54


          fix: handle errors in store.set method and return result status

c55316c


          updating with emitter

e48dc6f


          adding in ignore on code coverage

d38afc2


          adding in tests

c5e15e7


          fixing to handle set void stores

d533f99

jaredwray merged commit 240cb9e into jaredwray:main

5 checks passed

Owner

jaredwray commented Dec 11, 2024

@Sadzurami - thanks so much for this fix. I added in the linting and tests to make it work. Should have this fix rolled out in 2-3 weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet