Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add noNamespaceAffectsAll option #1243

Merged

Conversation

mahdavipanah
Copy link
Contributor

@mahdavipanah mahdavipanah commented Dec 10, 2024

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?
This PR is a follow-up on issue #1222 which I reported earlier. It adds an option to the adapter's API called noNamespacesAffectsAll and if is set to true and namespace is undefined:

  • clear method will use FLUSHDB command
  • iterator method will return all keys regardless of having a namespace prefix

The behavior of these methods will remain the same in cluster mode.
This option has a default value of false for backward compatibility so this PR does not introduce a breaking change.

@jaredwray jaredwray merged commit b6c1080 into jaredwray:main Dec 10, 2024
5 checks passed
@jaredwray
Copy link
Owner

@mahdavipanah - thanks for doing this. I should have this released in the next couple weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants