Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding in etcd as iterable #1228

Merged
merged 2 commits into from
Dec 7, 2024
Merged

feat: adding in etcd as iterable #1228

merged 2 commits into from
Dec 7, 2024

Conversation

MAXLZ1
Copy link
Contributor

@MAXLZ1 MAXLZ1 commented Dec 6, 2024

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
close #1227

To make the test pass, I modified the package.json of the etcd package so that keyv points to the package in the workspace.

@jaredwray
Copy link
Owner

@MAXLZ1 - looks like there are some errors that need to get resolved. Also, did you add code for etcd to do iteration?

@@ -42,6 +43,7 @@ export class KeyvEtcd<Value = any> extends EventEmitter {
url: '127.0.0.1:2379',
...url,
...options,
dialect: 'etcd',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the dialect: 'etcd' option when initializing KeyvEtcd.

@@ -89,6 +89,7 @@ const iterableAdapters = [
'mongo',
'redis',
'valkey',
'etcd',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add etcd to iterableAdapters.

@jaredwray jaredwray merged commit 1373c97 into jaredwray:main Dec 7, 2024
5 checks passed
@jaredwray
Copy link
Owner

@MAXLZ1 - thanks so much and we should have this update roll out in the next couple weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keyv.iterator is not a function when using KeyvEtcd
2 participants