feat: adding in etcd as iterable #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MAXLZ1 - looks like there are some errors that need to get resolved. Also, did you add code for etcd to do iteration? |
MAXLZ1
commented
Dec 7, 2024
| @@ -42,6 +43,7 @@ export class KeyvEtcd<Value = any> extends EventEmitter { | |||
| url: '127.0.0.1:2379', | |||
| ...url, | |||
| ...options, | |||
| dialect: 'etcd', | |||
There was a problem hiding this comment.
I added the dialect: 'etcd' option when initializing KeyvEtcd.
| @@ -89,6 +89,7 @@ const iterableAdapters = [ | |||
| 'mongo', | |||
| 'redis', | |||
| 'valkey', | |||
| 'etcd', | |||
There was a problem hiding this comment.
Add etcd to iterableAdapters.
|
@MAXLZ1 - thanks so much and we should have this update roll out in the next couple weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
close #1227
To make the test pass, I modified the package.json of the etcd package so that keyv points to the package in the workspace.