Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only update share counts when number goes up #51

Closed
billerickson opened this issue Jun 7, 2018 · 2 comments
Closed

Only update share counts when number goes up #51

billerickson opened this issue Jun 7, 2018 · 2 comments
Milestone

Comments

@billerickson
Copy link
Collaborator

Currently we update a post's share data with whatever is received from the API. This leads to the following issues:

  • If API is down, exceeded quota, or has incorrect data for some reason, share counts go to zero.
  • Pinterest shares fluctuate and some people get nervous when they see the Pinterest count go down
@jaredatch jaredatch added this to the 1.3.0 milestone Jun 7, 2018
@jaredatch jaredatch modified the milestones: 1.3.0, 1.4.0 May 13, 2019
@jaredatch
Copy link
Owner

We need to ideally prioritize this for 1.4.

A few weeks ago there were a few days all Pinterest counts went to 0 from the Shared Count API due to latency issues with the Pinterest API. So all those counts were lost for a few days.

If anything ever happens to the SC API (either entirely or just certain counts like this instance), having this in place would prevent major damage until alternatives can be considered.

@billerickson
Copy link
Collaborator Author

@jaredatch Can you look this over when you get a chance and make sure it works as you expected? d4d2fbe

billerickson added a commit that referenced this issue Sep 15, 2019
only update count if new count > old count, fixes #51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants