Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

U+0023 NUMBER SIGN (#) etc. affects the markdown string #9

Closed
jamesohortle opened this issue Nov 21, 2019 · 0 comments
Closed

U+0023 NUMBER SIGN (#) etc. affects the markdown string #9

jamesohortle opened this issue Nov 21, 2019 · 0 comments
Assignees
@jamesohortle
Labels
bug Something isn't working

Comments

@jamesohortle
Copy link
Owner

Hovering over

"\u0023"

leads to

Number Sign (UnicodeHover)

being rendered. I.e., we make the markdown string via

new vscode.MarkdownString("# Number Sign (UnicodeHover)");

which leads to a title being rendered.

All symbols that control how markdown is displayed need to be escaped.
@jamesohortle jamesohortle added the bug Something isn't working label Nov 21, 2019
@jamesohortle jamesohortle self-assigned this Nov 21, 2019
jamesohortle referenced this issue Nov 21, 2019
@jamesohortle
Add tests for rendering issues #6.
a280003
jamesohortle added a commit that referenced this issue Nov 21, 2019
@jamesohortle
Merge branch 'dev'
fa67ab6 
* dev:
  Update README.md.
  Update README.md.
  Provide hover for CSS files: \1234, etc.
  Fix a comment.
  Add tests for rendering issues #6.
  Fix rendering (fixes #9 ).
  Remove unneeded data.
  Provide support for HTML: decimal, hexadecimal and named character references/entities.
  Split and rename providers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesohortle jamesohortle

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jamesohortle