Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configurable queue consummation delay #411

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

kmakris23
Copy link

Issue: #409

Copy link
Owner

@jamesmh jamesmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the contribution!

I have a few improvements that I think will (a) help the code and (b) enable us to add some tests here.

Also, let's add some user documentation for this! In the file DocsV2/docs/Queuing/README.md you can add the following to the Adjusting Consummation Delay section:


Alternatively, you can adjust the consummation delay using AddQueue:

services.AddQueue(queueOptions => {
    // Consume queue every 5 seconds.
    queueOptions.ConsummationDelay = 5;
});

:::tip
QueueOptions will take precedence over your configuration file if both are defined.
:::


@jamesmh jamesmh self-assigned this Jan 17, 2025
@kmakris23
Copy link
Author

Hi @jamesmh , thanks for your reply. I have updated the code with the required changes. I will be very happy to see it once you have free time.

@kmakris23 kmakris23 requested a review from jamesmh February 6, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants