Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(images): add support for tapd v0.3.0-alpha #787

Merged
merged 9 commits into from
Oct 20, 2023
Merged

feat(images): add support for tapd v0.3.0-alpha #787

merged 9 commits into from
Oct 20, 2023

Conversation

jamaljsr
Copy link
Owner

The next version of tapd was just tagged and there are many improvements & breaking changes. This PR updates Polar to work with this latest release.

I'll leave this PR as a draft until the RC cycle is completed and the final version of tapd ships.

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9931a48) 100.00% compared to head (ae51f92) 100.00%.
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #787   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          139       139           
  Lines         4334      4356   +22     
  Branches       818       823    +5     
=========================================
+ Hits          4334      4356   +22     
Files Coverage Δ
src/components/common/AdvancedOptionsModal.tsx 100.00% <100.00%> (ø)
...components/designer/tap/actions/MintAssetModal.tsx 100.00% <100.00%> (ø)
...omponents/designer/tap/actions/NewAddressModal.tsx 100.00% <100.00%> (ø)
...components/designer/tap/actions/SendAssetModal.tsx 100.00% <ø> (ø)
...c/components/designer/tap/info/AssetInfoDrawer.tsx 100.00% <100.00%> (ø)
src/components/nodeImages/CustomImageModal.tsx 100.00% <ø> (ø)
src/lib/tap/tapd/tapdService.ts 100.00% <100.00%> (ø)
src/store/models/app.ts 100.00% <100.00%> (ø)
src/store/models/network.ts 100.00% <100.00%> (ø)
src/store/models/tap.ts 100.00% <100.00%> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamaljsr jamaljsr force-pushed the tapd-v3 branch 3 times, most recently from c4847cb to b5c1922 Compare October 12, 2023 14:07
@jamaljsr jamaljsr force-pushed the tapd-v3 branch 3 times, most recently from 2ee673e to 78403d5 Compare October 18, 2023 06:03
@jamaljsr jamaljsr marked this pull request as ready for review October 18, 2023 14:03
@jamaljsr jamaljsr merged commit b1b9bc2 into master Oct 20, 2023
@jamaljsr jamaljsr deleted the tapd-v3 branch October 20, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants