add longest increasing subsequence in JavaScript #2917
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MastersAbh
requested changes
May 19, 2020
| function lengthOfLIS(nums){ | ||
|
|
||
| //temporary array to save subsequence length values from that index | ||
| var arr = Array(nums.length); |
There was a problem hiding this comment.
looks like 2 space indentation, please change to 4 spaces
| var arr = Array(nums.length); | ||
| //maxLen will store the result | ||
| maxLen = 0; | ||
| for(var i = 0 ; i< nums.length;i++){ |
|
|
||
| //Examples | ||
|
|
||
| a1 = [1,2,3]; |
There was a problem hiding this comment.
please use dynamic inputs
|
Are you working on it? |
|
Hi @anirudh-kac , I dont see any update from you for over 15 days, so we are closing the PR. in case you want to rework on this, please reach out/ raise a new PR before deadline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2253
Checklist:
Languages Used:
Files Added: