-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tree_Preorder_Traversal.js added #2649
Conversation
Indentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation is improper throughout the file. Please add 4 space indentation at the start of each function block, if block. You can refer to already existing code in repository to understand what is 4 space indentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the functions inside class Binary Search Tree should be indented 4 spaces. Also leave a blank line between functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest looks good. Make that one change and then squash your commits. I will approve and merge.
Please squash your commits so that it can be merged. |
Mam, I am unable to squash all the commits, can I make a new pull request in which everything will be perfect enough to merge it :) |
You can do that. But It is best that you learn to do it @afroz23, because in every PR you will be asked to squash commits. There are youtube videos also on how to squash commits. |
Fixes #2550
Checklist:
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
Changes proposed in this pull request:
Languages Used:
Files Added:
Thanks!