Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree_Preorder_Traversal.js added #2649

Closed
wants to merge 14 commits into from
Closed

Conversation

afroz23
Copy link
Contributor

@afroz23 afroz23 commented Mar 29, 2020

Fixes #2550

Checklist:

  • 4 space indentation.
  • Coding conventions are followed.
  • Input is taken dynamically.
  • Sample Input / Output is added at the end of file.
  • Logic Documentation (Comments).
  • File names are correct.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

Changes proposed in this pull request:

  • Tree_Preorder_Traversal.js added

Languages Used:

  • javascript

Files Added:

  • Tree_Preorder_Traversal.js

We're happy to help you get this ready -- don't be afraid to ask for help.

Thanks!

@afroz23 afroz23 mentioned this pull request Apr 3, 2020
15 tasks
Copy link
Collaborator

@singh-shreya6 singh-shreya6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is improper throughout the file. Please add 4 space indentation at the start of each function block, if block. You can refer to already existing code in repository to understand what is 4 space indentation.

@afroz23 afroz23 requested a review from singh-shreya6 April 8, 2020 18:26
Copy link
Collaborator

@singh-shreya6 singh-shreya6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the functions inside class Binary Search Tree should be indented 4 spaces. Also leave a blank line between functions.

@afroz23 afroz23 requested a review from singh-shreya6 April 10, 2020 15:48
Copy link
Collaborator

@singh-shreya6 singh-shreya6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks good. Make that one change and then squash your commits. I will approve and merge.

singh-shreya6
singh-shreya6 previously approved these changes Apr 13, 2020
@singh-shreya6
Copy link
Collaborator

Please squash your commits so that it can be merged.

@afroz23
Copy link
Contributor Author

afroz23 commented Apr 13, 2020

Mam, I am unable to squash all the commits, can I make a new pull request in which everything will be perfect enough to merge it :)

@singh-shreya6
Copy link
Collaborator

You can do that. But It is best that you learn to do it @afroz23, because in every PR you will be asked to squash commits. There are youtube videos also on how to squash commits.

@afroz23 afroz23 closed this Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tree Preorder Traversal
2 participants