If emit error when max connections reties has been reached #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added the 'connect' event listener to socket to reset the connection retries counter and 'error' emit to the transport when the maximum connect retries is reached and the transport is 'silent' mode
I added a test to check that transport emit an 'error' message when it reaches the maximum connection retries and it swaps to ```silent``` mode
jaakkos
added a commit
that referenced
this pull request
Nov 15, 2013
…eached If emit error when max connections reties has been reached
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the issue #5 which I saw after I realised of it.
I provided test for it as well.