Extract a transformer method for finer control of the formats and fields sent to logstash #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lds sent to logstash
|
@djMax the build failed in a dep due to node 0.12 and the use of |
djMax
reviewed
Oct 26, 2017
lib/winston-logstash.js
Outdated
| @@ -50,6 +50,7 @@ var Logstash = exports.Logstash = function (options) { | |||
| this.strip_colors = options.strip_colors || false; | |||
| this.label = options.label || this.node_name; | |||
| this.meta_defaults = options.meta || {}; | |||
| this.transformer = options.transformer || defaultTransformer; | |||
There was a problem hiding this comment.
I know this is super nitpicky, but could you change the name of this to "transform"? Seems more in line with naming conventions I've seen.
djMax
approved these changes
Oct 29, 2017
|
Any news of a release or is this blocked by #47 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a new option
transformeras a function so that a client can exactly control what is sent to logstash.