Various fixes for php 8.1 compatibility #370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thanks for the PR. Would it be possible to split PHP8.1 specific fixes from whitespace cleanup? |
Merged
|
I can confirm, that this patch is required for php-8.1 and works. |
|
Thanks for the PR, but I am closing it because it contains whitespace changes that are undesirable and there is a duplicate pull request without them: #372 |
|
Thanks - the core changes presented here have now been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are breaking changes in 8.1 to the ArrayAccess interface. The changes adapt to the new typed interface.Various style fixes and an updated composer file. Since older php version will not be compatible, I am cutting any references in the travis file as well.
Edit: Found a more elegant solution by just annotating the ArrayAccess methods with
#[\ReturnTypeWillChange]. This way everything stays backwards compatible and it works with php 8.1 as well.