Backport recent fixes #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jtojnar
commented
Mar 7, 2023
jtojnar
commented
- ContentExtractor: clear image property on reset
- Graby::convert2Utf8: Allow spaces around HTML attributes
The property was introduced in j0k3r@b5d8ad4 without reset method being made aware of it. As a result, Graby might have returned an image from a previous item, when the Graby instance is re-used (like Wallabag does). Ideally, we would create a fresh ContentExtractor for each URL to preempt issues like this. (cherry picked from commit ac2b69a)
HTML attributes can contain a spaces around the equal sign: https://html.spec.whatwg.org/multipage/syntax.html#attributes-2 Fixes: j0k3r#302 (cherry picked from commit 037810a)
j0k3r
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.