Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test failures for paddle - manipulation.reshape #28281

Closed
wants to merge 2 commits into from

Conversation

us
Copy link

@us us commented Feb 13, 2024

PR Description

Related Issue

Closes #28280

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for supporting Ivy! 🎉
Join the conversation in our Discord.

For every PR opened, we run unit tests and comment the results in the PR to ensure the functionality remains intact.
Please make sure they are passing. 💪

If you want to check them from the action runners, you can open the display_test_results job. 👀
It contains the following two sections:

  • Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
  • New Failures Introduced: This lists the tests that fail on this PR.

Keep in mind that we will assign an engineer for this task and they will look at it based on the workload that they have, kindly be patient 😄.

@us us changed the title Fixed test failures for paddle - manipulation.reshape fix: test failures for paddle - manipulation.reshape Feb 13, 2024
@us us force-pushed the fix_paddle_manipulation_reshape branch from a388e4d to 1139378 Compare February 13, 2024 19:09
@us us force-pushed the fix_paddle_manipulation_reshape branch from 78374f2 to 672f8d1 Compare February 13, 2024 19:13
Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @us
Thanks for the PR.
Are we sure these types are not supported for reshape.
I checked int8 and int8 with paddle reshape and they seem to work.
image
I have checked with the others you have specified as unsupported but could you update this to only include unsupported types pls.
Feel free to ask if something is unclear. Thank you very much :)

@Ishticode Ishticode assigned Ishticode and unassigned NiteshK84 Feb 22, 2024
@Ishticode
Copy link
Contributor

Thank you very much for the PR. Closing this due to lack of activity with changes requested remaining unresolved for over a month. Please feel free to reopen if you would like to continue working on this. :)

@Ishticode Ishticode closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Ivy Failing Test: paddle - manipulation.reshape
5 participants