Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove shebang from generated bash and tcsh scripts #61

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

amurzeau
Copy link
Contributor

@amurzeau amurzeau commented Dec 1, 2021

I'm proposing this changes because:

  • Auto completion scripts are not meant to be executable, but only sourced.
  • On Debian systems, bash autocompletion scripts have a warning if they contains a hashbang

See also: https://salsa.debian.org/lintian/lintian/-/merge_requests/292#note_139419

Auto completion scripts are not meant to be executable, but only sourced.

See also: https://salsa.debian.org/lintian/lintian/-/merge_requests/292#note_139419
Copy link
Collaborator

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@casperdcl casperdcl merged commit 948d7cc into iterative:master Dec 2, 2021
@casperdcl
Copy link
Collaborator

/tag v1.5.2 948d7cc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants