Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix docs hyperlinks #133

Merged
merged 3 commits into from
Apr 2, 2023
Merged

fix docs hyperlinks #133

merged 3 commits into from
Apr 2, 2023

Conversation

casperdcl
Copy link
Collaborator

@casperdcl casperdcl commented Apr 2, 2023 •
edited
Loading

  • add public typehints
  • docs: tidy docstrings
  • docs: fix hyperlinks

@casperdcl casperdcl self-assigned this Apr 2, 2023
@casperdcl casperdcl added documentation Markdown files testing Unit tests & debugging technical-debt Refactoring, linting & tidying labels Apr 2, 2023
@casperdcl casperdcl changed the title test coverage fix docs hyperlinks, increase test coverage Apr 2, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (68ac169) 91.39% compared to head (743dd7a) 91.39%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #133   +/-   ##
=======================================
  Coverage   91.39%   91.39%           
=======================================
  Files           3        3           
  Lines         337      337           
=======================================
  Hits          308      308           
  Misses         29       29
Impacted Files Coverage Δ
shtab/__init__.py 93.81% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@casperdcl casperdcl changed the title fix docs hyperlinks, increase test coverage fix docs hyperlinks Apr 2, 2023
@casperdcl casperdcl removed the testing Unit tests & debugging label Apr 2, 2023
omesser
omesser approved these changes Apr 2, 2023
View reviewed changes
Copy link
Contributor

@omesser omesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 Thank you @casperdcl

@omesser omesser merged commit 80a1050 into main Apr 2, 2023
@omesser omesser deleted the test-coverage branch April 2, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x2b3bfa0 0x2b3bfa0 0x2b3bfa0 approved these changes

@omesser omesser omesser approved these changes

@shcheklein shcheklein Awaiting requested review from shcheklein

Assignees

@casperdcl casperdcl

Labels
documentation Markdown files technical-debt Refactoring, linting & tidying
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@casperdcl @codecov-commenter @0x2b3bfa0 @omesser