Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] why shtab don't have shell completion by itself? #89

Closed
Freed-Wu opened this issue Aug 27, 2022 · 3 comments
Closed

[feature] why shtab don't have shell completion by itself? #89

Freed-Wu opened this issue Aug 27, 2022 · 3 comments
Labels
external-request You asked, we did good-first-issue Good for newcomers (good-first-issue) technical-debt Refactoring, linting & tidying

Comments

@Freed-Wu
Copy link
Contributor

I notice shtab.main.get_main_parser don't use shtab.add_argument_to. Can it do?
@casperdcl
Copy link
Collaborator

Doggfooding à la https://docs.iterative.ai/shtab/use/#library-usage? Sure...

@casperdcl casperdcl added good-first-issue Good for newcomers (good-first-issue) technical-debt Refactoring, linting & tidying labels Oct 26, 2022
@Freed-Wu
Copy link
Contributor Author

I know we can use shtab --shell=tcsh shtab.main.get_main_parser --error-unimportable | sudo tee /etc/profile.d/shtab.completion.csh to generate shell completion. I want to know
why not shtab --print-completion XXX? The latter looks better.

@casperdcl
Copy link
Collaborator

Yes makes sense, feel free to add it :)

@casperdcl casperdcl added the external-request You asked, we did label Oct 29, 2022
casperdcl added a commit that referenced this issue Apr 2, 2023
@casperdcl
Merge pull request #114 from Freed-Wu/iss89
68ac169 
Fix #89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
external-request You asked, we did good-first-issue Good for newcomers (good-first-issue) technical-debt Refactoring, linting & tidying
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@casperdcl @Freed-Wu