add API to check whether it's a GTO repo #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #187 +/- ##
==========================================
+ Coverage 83.26% 83.35% +0.08%
==========================================
Files 16 16
Lines 1494 1514 +20
==========================================
+ Hits 1244 1262 +18
- Misses 250 252 +2
Continue to review full report at Codecov.
|
aguschin
commented
Jun 24, 2022
gto/api.py
Outdated
Comment on lines
22
to
27
| def is_gto_repo(repo: Union[str, Repo]): | ||
| """Check if repo is a gto repo""" | ||
| try: | ||
| return GitRegistry.from_repo(repo).is_gto_repo() | ||
| except NoRepo: | ||
| return False |
There was a problem hiding this comment.
Looks a bit strange to me having this in a public API, TBH.
There was a problem hiding this comment.
Making that method private since I think it's some extra case not needed for every GTO API user.
amritghimire
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #186