Enhance sorting #162
Merged
Enhance sorting #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gto/base.py
Outdated
| if sort == VersionSort.SemVer: | ||
| # sorting SemVer versions in a right way | ||
| sorted_versions = sorted( | ||
| (v for v in versions if v.is_registered), |
There was a problem hiding this comment.
@aguschin We don't store is_registered or discovered tag with us. While using the method with dict, v.is_registered may throw AttributeError here.
There was a problem hiding this comment.
Ok, I see your example repo doesn't include these cases, so I think you didn't implement support for not is_registered versions.
There was a problem hiding this comment.
@amritghimire, I've made it infer whether version is SemVer or just a hexsha. Will it work now?
There was a problem hiding this comment.
Do you need something else to be implemented now? Otherwise I'll go ahead and create new release.
There was a problem hiding this comment.
That is all @aguschin . Thanks for continuous updates to the package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@amritghimire, please check out this PR. You need
def sort_versionsinbase.pyNote, that BaseVersion in GTO has
is_registeredanddiscoveredatrrs, which I use for sorting also. Not sure you have them already.is_registered == Trueindicates that it's an explicitly registered SemVer, e.g.v1.2.3.is_registered == Falseindicates that it wasn't explicitly registered, but model in this hexsha was promoted to some stage (e.g. withmodel#prod#1git tag). In this case GTO assumes it's a version, though not explicitly registered. For the version name, GTO uses commit hash.Considering #132
is_registered == Falsemaybe deprecated. But we need a decision there first.cc @shcheklein: #132 is something I can use your help with.