Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm: fix network leak (#13836) #293

Merged

Conversation

bianpengyuan
Copy link

Signed-off-by: Kuat Yessenov kuat@google.com

Signed-off-by: Kuat kyessenov@users.noreply.github.com

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]

Signed-off-by: Kuat Yessenov <kuat@google.com>

Signed-off-by: Kuat <kyessenov@users.noreply.github.com>
@bianpengyuan
Copy link
Author

istio/istio#24720

@kyessenov
Copy link

/lgtm
/approve

@bianpengyuan
Copy link
Author

/retest

1 similar comment
@bianpengyuan
Copy link
Author

/retest

@bianpengyuan
Copy link
Author

@PiotrSikora @kyessenov Do you know if //test/integration:tcp_proxy_integration_test is a known flake? It failed 100% in CI but I cannot imagine how this PR could cause it...

Please advice since we hope to get this in as soon as possible in order to catch 1.7.7.

@bianpengyuan
Copy link
Author

/retest

@PiotrSikora
Copy link

It's a flake, give it a few more tries. It's unrelated to this PR.

@jwendell
Copy link
Member

/retest

1 similar comment
@tariq1890
Copy link

/retest

@bianpengyuan
Copy link
Author

bianpengyuan commented Jan 28, 2021

I probably will just disable the test for now when testing with tsan. There is no meaning to keep retrying a 100% failing flaky test.

Signed-off-by: Pengyuan Bian <bianpengyuan@google.com>
@bianpengyuan
Copy link
Author

Ok great.. now it fails because of a different reason:

ERROR: Analysis of target '//:envoy_binary_test' failed; build aborted: Analysis of target '@envoy//bazel/foreign_cc:zlib' failed
INFO: Elapsed time: 15.665s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (376 packages loaded, 2575 targets configured)
ERROR: Couldn't start the build. Unable to run tests
FAILED: Build did NOT complete successfully (376 packages loaded, 2575 targets configured)
./ci/do_ci.sh: line 32: pushd: bazel-testlogs: No such file or directory

Looks like a non-retryable failure.. Will retry it one more time, if it still fails, we should make tsan non-required and debug it afterwards.

@bianpengyuan
Copy link
Author

/retest

@kyessenov
Copy link

You could add flaky_test_attempts if it's really bad. Some tests are flakey even without Tsan.

@istio-testing
Copy link

@bianpengyuan: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
test-tsan_envoy_release-1.7 3731665 link /test test-tsan_envoy_release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan
Copy link
Author

istio/test-infra#3160

@bianpengyuan
Copy link
Author

/retest

@istio-testing istio-testing merged commit 4abbbc0 into istio:release-1.7 Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants