-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasm: fix network leak (#13836) #293
wasm: fix network leak (#13836) #293
Conversation
Signed-off-by: Kuat Yessenov <kuat@google.com> Signed-off-by: Kuat <kyessenov@users.noreply.github.com>
/lgtm |
/retest |
1 similar comment
/retest |
@PiotrSikora @kyessenov Do you know if Please advice since we hope to get this in as soon as possible in order to catch 1.7.7. |
/retest |
It's a flake, give it a few more tries. It's unrelated to this PR. |
/retest |
1 similar comment
/retest |
I probably will just disable the test for now when testing with tsan. There is no meaning to keep retrying a 100% failing flaky test. |
Signed-off-by: Pengyuan Bian <bianpengyuan@google.com>
Ok great.. now it fails because of a different reason:
Looks like a non-retryable failure.. Will retry it one more time, if it still fails, we should make tsan non-required and debug it afterwards. |
/retest |
You could add flaky_test_attempts if it's really bad. Some tests are flakey even without Tsan. |
@bianpengyuan: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
Signed-off-by: Kuat Yessenov kuat@google.com
Signed-off-by: Kuat kyessenov@users.noreply.github.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]