Prevent callback from being called twice #145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@isaacs ping? |
|
@isaacs Is there a reason this PR hasn't been merged? |
|
@isaacs bump |
|
@isaacs we're noticing same issue, any update on when this can be merged? |
|
No longer applicable in v4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm one of the maintainers of
fs-extra. Atfs-extrawe maintain a fork of rimraf internally. A user reported a bug in rimraf; I applied a patch to our fork, and I'm forwarding the patch upstream.Here is the issue discussion: jprichardson/node-fs-extra#392