Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fake5 Runner task #16

Merged
merged 7 commits into from
Aug 29, 2018
Merged

Fake5 Runner task #16

merged 7 commits into from
Aug 29, 2018

Conversation

matthid
Copy link
Collaborator

@matthid matthid commented Aug 25, 2018

Basically a full-featured fake 5 runner task. Even added support for secret & encrypted variables to fake. However secret variables are only usable when a new Fake.BuildServer.TeamFoundation package is released (probably soon)

Similar to other tasks it will ask the user for a version and download and cache fake. The task currently requires DotNetCore to be available (the easiest way is to use the DotNetCoreInstaller task). We can consider lifting that requirement and download the self-contained package instead (but that was out of scope for the first implementation)

I guess docs are still missing

@matthid
Copy link
Collaborator Author

matthid commented Aug 25, 2018

To dogfood this in FAKE I need to add another task in order to only generate the secret variable stuff, this task is probably not very useful to anyone else but FAKE, not sure if we should add it here (it might be useful if you are not using the runner task and still want to access the secret variables)?

Revert changes in PaketRestore task
@matthid matthid mentioned this pull request Aug 25, 2018
2 tasks
@matthid
Copy link
Collaborator Author

matthid commented Aug 26, 2018

I'm quite positive that this is ready, I hope I didn't break the PaketRestore task

@matthid
Copy link
Collaborator Author

matthid commented Aug 27, 2018

Maybe for marketing purposes we should have a separate "fake" extension (to be independent of "F#")? However I'm fine with having everything here in a single repository. What do you think?

@isaacabraham
Copy link
Owner

@matthid I had the same thought re: FAKE - I'm happy to support either model :-)

@isaacabraham isaacabraham merged commit 831da2d into isaacabraham:master Aug 29, 2018
@isaacabraham
Copy link
Owner

And thanks for adding this :-)

@matthid
Copy link
Collaborator Author

matthid commented Aug 29, 2018

Thinking this further: "Paket" is not a "F# helper" either... Maybe we should rename this completely :/

@isaacabraham
Copy link
Owner

Yeah, it is a bit misleading. Not sure what to rename it to, as it has an F# runner there too.

@matthid
Copy link
Collaborator Author

matthid commented Aug 29, 2018

The good thing about a single extension is that people need to ask their admins only once, while with 3 extensions (Paket, Fake, F#) they might need to ask multiple times :/

@matthid
Copy link
Collaborator Author

matthid commented Aug 29, 2018

And realistically that the tasks are used and installed together makes completely sense to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants