fix #20137
Closed
fix #20137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please use proper sentences and descriptions in pull requests. |
benvanik
reviewed
Mar 1, 2025
| return success(); | ||
| } else { | ||
| MemRefType srcType = cast<MemRefType>(srcType); | ||
| // TODO (ita9naiwa): add this case : add this case |
There was a problem hiding this comment.
Follow the // TODO(ita9naiwa): <an description of what is to be done>. format for TODO messages.
TODOs added to the codebase should either be fully descriptive enough for someone else to come along and implement it with your name indicating you plan to do it ASAP or reference an issue instead (// TODO(#1234): <description>.. "add this case" is something you can use locally when developing but it's not something that belongs in the repository.
|
Oh sorry, I thought I meant to merge my local branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.