Reland "[spirv][vulkan] Enable device query generation and execution" #16075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moto Edge X30 supports VK_KHR_16bit_storage for only storage buffers, but not uniform buffers, see https://vulkan.gpuinfo.org/displayreport.php?id=14481#features_extensions We request both bits. Disable running such tests there.
antiagainst
force-pushed
the
spirv-fix-adreno-f16
branch
from
ffe572c to
8a710e5
Compare
As long as the `shaderIntegerDotProduct` bit is true, we can use all the integer dot product instructions in SPIR-V. Whether it's accelerated or not does not matter for the purpose of deciding whether the SPIR-V blob is runnable.
|
Verified that cb36ec1 disables the test for Adreno (https://github.com/openxla/iree/actions/runs/7456775700/job/20288120142?pr=16075) but not Mali (https://github.com/openxla/iree/actions/runs/7456775700/job/20288120028?pr=16075) |
This reverts commit 8a710e5.
antiagainst
changed the title
Abbreviated Benchmark Summary@ commit 8a7b30a73d838504f956288f3faca02aea8f01f9 (vs. base 282ab7758324d175179988d315edf6a2f38d5b0c) Improved Latencies 🎉
No improved or regressed compilation metrics 🏖️ For more information: |
antiagainst
requested review from
ScottTodd,
MaheshRavishankar and
benvanik
as code owners
kuhar
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit relands #15977
with the following changes:
Moto Edge X30 supports VK_KHR_16bit_storage for only storage
buffers, but not uniform buffers, see
https://vulkan.gpuinfo.org/displayreport.php?id=14481#features_extensions
We request both bits.
shaderIntegerDotProductbit is true, we can use all the integerdot product instructions in SPIR-V. Whether it's accelerated or not
does not matter for the purpose of deciding whether the SPIR-V blob
is runnable.