Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update executable linking utilities/passes to support hal.executable.condition. #15786

Closed
benvanik opened this issue Dec 4, 2023 · 0 comments · Fixed by #15977
Closed

Update executable linking utilities/passes to support hal.executable.condition. #15786

benvanik opened this issue Dec 4, 2023 · 0 comments · Fixed by #15977
Assignees
Labels
compiler/dialects Relating to the IREE compiler dialects (flow, hal, vm)

Comments

@benvanik
Copy link
Collaborator

benvanik commented Dec 4, 2023

Currently linking creates one variant per target attr and links all variants with matching targets as that previously was the only way to distinguish variants. This worked prior to hal.executable.condition being added to allow for customized load conditioning and we need to update the linking process to create one variant per unique target and condition op (if present) - or bake out the target attr selection into condition ops and just bucket on that op.

We aren't currently generating hal.executable.condition in any backends but we'll need to fix this prior to turning it on.

@benvanik benvanik added the compiler/dialects Relating to the IREE compiler dialects (flow, hal, vm) label Dec 4, 2023
antiagainst added a commit that referenced this issue Jan 8, 2024
This commit adds a pass to materialize executable required SPIR-V
capabilities into proper device queries inside the associated
hal.executable.condition ops. Linking is updated accordingly to
unique and preseve the feature checks. The Vulkan HAL driver
is updated accordingly to probe the implementation and match
against the device queries.

Fixes #15786
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/dialects Relating to the IREE compiler dialects (flow, hal, vm)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants