Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zeroize: Rename bytes feature to bytes-preview #277

Merged
merged 1 commit into from
Oct 13, 2019

Conversation

tony-iqlusion
Copy link
Member

Since bytes isn't 1.0 yet and we'd like to reserve the right to either upgrade it to another 0.x version in the future, or upstream the implementation so we can remove the feature entirely, this changes the
feature name to bytes-preview and explicitly calls it out as not included in the SemVer guarantees for zeroize.

Ideally I think we can upstream it, especially after a 1.0 release of zeroize itself.

Since `bytes` isn't 1.0 yet and we'd like to reserve the right to either
upgrade it to another 0.x version in the future, or upstream the
implementation so we can remove the feature entirely, this changes the
feature name to `bytes-preview` and explicitly calls it out as not
included in the SemVer guarantees for `zeroize`.

Ideally I think we can upstream it, especially after a 1.0 release of
`zeroize` itself.
@tony-iqlusion tony-iqlusion merged commit 518310c into develop Oct 13, 2019
@tony-iqlusion tony-iqlusion deleted the zeroize/rename-bytes-preview-cargo-feature branch October 13, 2019 20:55
@tony-iqlusion tony-iqlusion mentioned this pull request Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant