Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap: port to core24 #666

Merged
merged 4 commits into from
Feb 16, 2025
Merged

snap: port to core24 #666

merged 4 commits into from
Feb 16, 2025

Conversation

lidaobing
Copy link
Member

@lidaobing lidaobing commented Feb 16, 2025

Summary by Sourcery

Update snap to use core24. Update build and pull steps to use craftctl default. Update stage packages.

Build:

  • Update the base to core24 and switch to craftctl default for build and pull steps.
  • Update stage packages to use libgoogle-glog0v6t64 instead of libgoogle-glog0v5.
  • Remove sed command and related comment for updating the desktop file.
  • Remove commented-out line for running meson test command

Copy link

sourcery-ai bot commented Feb 16, 2025

Reviewer's Guide by Sourcery

This pull request ports the iptux snap to core24. This involves updating the base snap, build dependencies, and build commands.

Updated class diagram for build dependencies

classDiagram
    class core22 {
        stage-packages
            - libgflags2.2
            - libgoogle-glog0v5
            - libjsoncpp25
            - libsigc++-2.0-0v5
            - libayatana-appindicator3-1
    }
    class core24 {
        stage-packages
            - libgflags2.2
            - libgoogle-glog0v6t64
            - libjsoncpp25
            - libsigc++-2.0-0v5
            - libayatana-appindicator3-1
    }
    core22 -- core24: libgoogle-glog version update
Loading

File-Level Changes

Change Details Files
Update base from core22 to core24.
  • Update the base field in snapcraft.yaml from core22 to core24.
snap/snapcraft.yaml
Update build dependencies.
  • Update libgoogle-glog dependency from libgoogle-glog0v5 to libgoogle-glog0v6t64.
snap/snapcraft.yaml
Update snapcraft commands.
  • Replaced snapcraftctl pull with craftctl default in override-pull.
  • Replaced snapcraftctl build with craftctl default in override-build.
  • Removed sed command in override-build.
snap/snapcraft.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lidaobing - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@lidaobing lidaobing marked this pull request as draft February 16, 2025 16:39
Copy link

github-actions bot commented Feb 16, 2025

Test Results

66 tests  ±0   66 ✅ ±0   2s ⏱️ -1s
32 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 5a3c5f8. ± Comparison against base commit c7c0958.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Feb 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.54%. Comparing base (c7c0958) to head (95505d3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #666   +/-   ##
=======================================
  Coverage   52.54%   52.54%           
=======================================
  Files          64       64           
  Lines        8579     8579           
=======================================
  Hits         4508     4508           
  Misses       4071     4071           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lidaobing lidaobing marked this pull request as ready for review February 16, 2025 17:07
@lidaobing lidaobing merged commit 19fa9be into master Feb 16, 2025
12 of 15 checks passed
@lidaobing lidaobing deleted the snap-core24 branch February 16, 2025 17:08
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lidaobing - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The removal of xvfb-run from the build steps suggests a potential shift in how tests are executed; ensure that the test environment is still adequately configured.
  • Consider adding a comment explaining why the override-pull and override-build steps were simplified to craftctl default.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant