-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
snap: port to core24 #666
snap: port to core24 #666
Conversation
Reviewer's Guide by SourceryThis pull request ports the iptux snap to core24. This involves updating the base snap, build dependencies, and build commands. Updated class diagram for build dependenciesclassDiagram
class core22 {
stage-packages
- libgflags2.2
- libgoogle-glog0v5
- libjsoncpp25
- libsigc++-2.0-0v5
- libayatana-appindicator3-1
}
class core24 {
stage-packages
- libgflags2.2
- libgoogle-glog0v6t64
- libjsoncpp25
- libsigc++-2.0-0v5
- libayatana-appindicator3-1
}
core22 -- core24: libgoogle-glog version update
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lidaobing - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #666 +/- ##
=======================================
Coverage 52.54% 52.54%
=======================================
Files 64 64
Lines 8579 8579
=======================================
Hits 4508 4508
Misses 4071 4071 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lidaobing - I've reviewed your changes - here's some feedback:
Overall Comments:
- The removal of
xvfb-run
from the build steps suggests a potential shift in how tests are executed; ensure that the test environment is still adequately configured. - Consider adding a comment explaining why the
override-pull
andoverride-build
steps were simplified tocraftctl default
.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Update snap to use core24. Update build and pull steps to use
craftctl default
. Update stage packages.Build:
craftctl default
for build and pull steps.libgoogle-glog0v6t64
instead oflibgoogle-glog0v5
.sed
command and related comment for updating the desktop file.meson test
command