Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapcraft: port to core22 #664

Merged
merged 1 commit into from
Feb 16, 2025
Merged

snapcraft: port to core22 #664

merged 1 commit into from
Feb 16, 2025

Conversation

lidaobing
Copy link
Member

@lidaobing lidaobing commented Feb 16, 2025

Summary by Sourcery

Build:

  • Update the snapcraft base to core22 and the gnome extension from gnome-3-38 to gnome. Update the libjsoncpp1 stage package to libjsoncpp25 and add libunwind8 to all architectures, removing the s390x workaround

Copy link

sourcery-ai bot commented Feb 16, 2025

Reviewer's Guide by Sourcery

This pull request ports the snapcraft.yaml configuration to core22. This involves updating the base from core20 to core22, updating the gnome extension, updating libjsoncpp, and removing the try conditional for libunwind8.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Update base from core20 to core22.
  • Update base from core20 to core22.
snap/snapcraft.yaml
Update gnome extension.
  • Update gnome extension from gnome-3-38 to gnome.
snap/snapcraft.yaml
Update libjsoncpp.
  • Update libjsoncpp from libjsoncpp1 to libjsoncpp25.
snap/snapcraft.yaml
Remove try conditional for libunwind8.
  • Remove try conditional for libunwind8.
snap/snapcraft.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@lidaobing lidaobing merged commit 9e917b7 into master Feb 16, 2025
11 of 14 checks passed
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lidaobing - I've reviewed your changes - here's some feedback:

Overall Comments:

  • It's great to see the move to core22, but make sure to test thoroughly for any regressions.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@lidaobing lidaobing deleted the snap-core22 branch February 16, 2025 16:04
Copy link

codecov bot commented Feb 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.54%. Comparing base (9adbf69) to head (8f3e96e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #664   +/-   ##
=======================================
  Coverage   52.54%   52.54%           
=======================================
  Files          64       64           
  Lines        8579     8579           
=======================================
  Hits         4508     4508           
  Misses       4071     4071           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant