-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
snapcraft: port to core22 #664
Conversation
Reviewer's Guide by SourceryThis pull request ports the snapcraft.yaml configuration to core22. This involves updating the base from core20 to core22, updating the gnome extension, updating libjsoncpp, and removing the try conditional for libunwind8. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lidaobing - I've reviewed your changes - here's some feedback:
Overall Comments:
- It's great to see the move to core22, but make sure to test thoroughly for any regressions.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #664 +/- ##
=======================================
Coverage 52.54% 52.54%
=======================================
Files 64 64
Lines 8579 8579
=======================================
Hits 4508 4508
Misses 4071 4071 ☔ View full report in Codecov by Sentry. |
Summary by Sourcery
Build: