-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve log (#554) #657
improve log (#554) #657
Conversation
Reviewer's Guide by SourceryThis PR improves the logging mechanism by modifying how logs are formatted and generated. The implementation replaces C++ thread identification with pthread functions, changes log level representation from strings to single characters, and adjusts both timestamp and filename formatting in log outputs. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lidaobing - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider verifying that using pthread_self() instead of std::this_thread::get_id() produces an easily readable thread identifier on all target platforms.
- Review whether representing log levels with a single character provides enough clarity for future debugging.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #657 +/- ##
==========================================
- Coverage 52.48% 52.47% -0.02%
==========================================
Files 64 64
Lines 8558 8558
==========================================
- Hits 4492 4491 -1
- Misses 4066 4067 +1 ☔ View full report in Codecov by Sentry. |
/close #554
Summary by Sourcery
Improve logging format. Use pthread instead of std::thread to get thread name. Simplify the log level output to a single character. Shorten the file name in the log output. Change the timestamp format to only include time and milliseconds.