fix iptux stackoverflow when receiving dir

[lidaobing]

/close #472

g_mkdir is macro define to mkidr, so when we call g_mkdir in AnalogFS::mkdir, it will call itself. cause stackoverflow.

Summary by Sourcery

Bug Fixes:

• Fixed a stack overflow error that occurred when creating directories during file transfer. The issue was caused by inadvertently calling mkdir recursively.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request addresses a stack overflow issue caused by the recursive invocation of the 'g_mkdir' macro within the 'AnalogFS::mkdir' method. The solution involves renaming and updating the directory creation method from 'mkdir' to 'makeDir' to prevent self-referential calls in both the implementation and its usage.

Updated Class Diagram for AnalogFS (Renaming mkdir to makeDir)

classDiagram
    class AnalogFS {
      +int open(const char* fn, int flags)
      +int open(const char* fn, int flags, mode_t mode)
      +int stat(const char* fn, struct ::stat* st)
      +int makeDir(const char* dir, mode_t mode)
      +int64_t ftwsize(const char* dir)
      +DIR* opendir(const char* dir)
    }
    note for AnalogFS "Renamed mkdir to makeDir to avoid recursive macro call causing stack overflow"

Loading

File-Level Changes

Change	Details	Files
Update of directory creation function usage in the file receiving process.	Replaced the call to 'afs.mkdir' with 'afs.makeDir' in RecvFileData.cpp for creating the file archive directory. Replaced the call to 'afs.mkdir' with 'afs.makeDir' in RecvFileData.cpp when handling directory entries.	src/iptux-core/internal/RecvFileData.cpp
Rename and update the directory creation function in the AnalogFS implementation.	Renamed the 'mkdir' method to 'makeDir' in the AnalogFS.cpp file to avoid recursive macro expansion. Updated the function declaration accordingly in the AnalogFS.h header file.	src/iptux-core/internal/AnalogFS.cpp src/iptux-core/internal/AnalogFS.h

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#472	Fix app crash when receiving a shared folder	✅

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @lidaobing - I've reviewed your changes - here's some feedback:

Overall Comments:

• Ensure all calls to the directory creation function have been updated to use makeDir to avoid inadvertent calls to the macro-expanded g_mkdir.
• Double-check that the interface change from mkdir to makeDir does not break any expected usage in the filesystem abstraction layer.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[github-actions]

Test Results

66 tests  ±0   66 ✅ ±0   1s ⏱️ -3s
32 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 6efeb55. ± Comparison against base commit a926505.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 52.48%. Comparing base (a926505) to head (6efeb55).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
src/iptux-core/internal/RecvFileData.cpp	0.00%	2 Missing ⚠️
src/iptux-core/internal/AnalogFS.cpp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #656      +/-   ##
==========================================
+ Coverage   52.47%   52.48%   +0.01%     
==========================================
  Files          64       64              
  Lines        8558     8558              
==========================================
+ Hits         4491     4492       +1     
+ Misses       4067     4066       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.