Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#627: fix wrap mode #628

Merged
merged 1 commit into from
Jul 13, 2024
Merged

#627: fix wrap mode #628

merged 1 commit into from
Jul 13, 2024

Conversation

lidaobing
Copy link
Member

@lidaobing lidaobing commented Jul 13, 2024

Summary by Sourcery

This pull request addresses an issue with the text wrapping mode in various text view widgets within the application. The wrapping mode has been updated to 'GTK_WRAP_WORD_CHAR' to ensure proper handling of both words and characters.

  • Bug Fixes:
    • Fixed text wrapping mode in input, history, and info areas to ensure proper word and character wrapping.

@lidaobing lidaobing linked an issue Jul 13, 2024 that may be closed by this pull request
Copy link

sourcery-ai bot commented Jul 13, 2024

Reviewer's Guide by Sourcery

This pull request addresses the text wrapping behavior in the application by changing the wrap mode of text views from GTK_WRAP_WORD and GTK_WRAP_NONE to GTK_WRAP_WORD_CHAR. This change ensures that text wraps at both word boundaries and character boundaries, improving the display of text in various dialog areas.

File-Level Changes

Files Changes
src/iptux/DialogBase.cpp
src/iptux/DialogPeer.cpp
Updated text view wrap modes to GTK_WRAP_WORD_CHAR for better text wrapping behavior.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lidaobing - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Copy link

codecov bot commented Jul 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.47%. Comparing base (e3ce5a8) to head (23ca0ca).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #628   +/-   ##
=======================================
  Coverage   52.47%   52.47%           
=======================================
  Files          64       64           
  Lines        8520     8520           
=======================================
  Hits         4471     4471           
  Misses       4049     4049           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lidaobing
Copy link
Member Author

image

@lidaobing lidaobing merged commit b852fbb into master Jul 13, 2024
16 checks passed
@lidaobing lidaobing deleted the 627-wrap-on-super-long-msg branch July 13, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrap on super long msg
1 participant