Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

send an image to friend, close window, then re-open, the image disappear #658

Closed
lidaobing opened this issue Feb 9, 2025 · 1 comment · Fixed by #659
Closed

send an image to friend, close window, then re-open, the image disappear #658

lidaobing opened this issue Feb 9, 2025 · 1 comment · Fixed by #659
Assignees
@lidaobing
Labels
1. Bug
Milestone
0.9.4

Comments

@lidaobing
Copy link
Member

lidaobing commented Feb 9, 2025 •
edited
Loading

introduced in #595
@lidaobing lidaobing added this to the 0.9.4 milestone Feb 9, 2025
@lidaobing lidaobing self-assigned this Feb 9, 2025
lidaobing added a commit that referenced this issue Feb 16, 2025
@lidaobing
#658: after close dialog and reopen, the image no longer exist (#659)
9adbf69 
1. restore the images from text-buffer after dialog reopened. (bug introduced in #595)
2. when dialog closed, it SHOULD remove the event listener on history text buffer (bug introduced in #595)
3. keep the sent-images(otherwise no way to restore the image), and keep it under the `~/.cache/iptux/sent-image/`
@lidaobing lidaobing linked a pull request Feb 16, 2025 that will close this issue
#658: after close dialog and reopen, the image no longer exist #659
Merged
@lidaobing
Copy link
Member Author

fixed in #659

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidaobing lidaobing

Labels
1. Bug
Projects
None yet
Milestone
0.9.4
Development

Successfully merging a pull request may close this issue.

#658: after close dialog and reopen, the image no longer exist iptux-src/iptux
1 participant
@lidaobing