This repository was archived by the owner on Aug 11, 2021. It is now read-only.
Fix/node10 #129
Merged
Fix/node10 #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes and issue with node 10 failures License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
chore: updates deps License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
10 tasks
daviddias
approved these changes
May 29, 2018
|
@diasdavid @vmx this is the last PR needed to resolve the js-ipfs node 10 build errors, ipfs/js-ipfs#1358. |
daviddias
reviewed
May 29, 2018
| @@ -49,7 +49,7 @@ | |||
| "interface-datastore": "~0.4.2", | |||
| "ipfs-block": "~0.7.1", | |||
| "ipfs-block-service": "~0.14.0", | |||
| "ipfs-repo": "~0.20.0", | |||
| "ipfs-repo": "~0.22.0", | |||
There was a problem hiding this comment.
Can we remove https://github.com/ipld/js-ipld/blob/master/src/index.js#L413-L440 so that we don't have to have so many deps as main deps?
Closed
vmx
approved these changes
May 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the version of ipfs-repo. This is to address an issue with js-ipfs failing to run on node 10 due to leveldown versions.
Depends on ipfs/js-ipfs-repo#168
Connects to ipfs/js-ipfs#1347