fix: ipfs-hosted redirects are not infinite #215
Conversation
There was a problem hiding this comment.
Thanks! Had no bandwidth today to review code, but if this data point is useful: I did run it locally against static http server and ?helia-sw=/ipns/docs.ipfs.tech and it no longer redirects to /ipns/docs.ipfs.tech so the infinite loop from #211 (comment) does not occur anymore.
| await $(execaOptions)`${kuboBin} config Addresses.Gateway /ip4/127.0.0.1/tcp/${gatewayPort}` | ||
| await $(execaOptions)`${kuboBin} config Addresses.API /ip4/127.0.0.1/tcp/0` | ||
| await $(execaOptions)`${kuboBin} config --json Bootstrap ${JSON.stringify([])}` | ||
| await $(execaOptions)`${kuboBin} config --json Swarm.DisableNatPortMap true` | ||
| await $(execaOptions)`${kuboBin} config --json Discovery.MDNS.Enabled false` | ||
| await $(execaOptions)`${kuboBin} config --json Gateway.NoFetch true` | ||
| await $(execaOptions)`${kuboBin} config --json Gateway.DeserializedResponses true` | ||
| await $(execaOptions)`${kuboBin} config --json Gateway.ExposeRoutingAPI false` | ||
| await $(execaOptions)`${kuboBin} config --json Gateway.HTTPHeaders.Access-Control-Allow-Origin ${JSON.stringify(['*'])}` | ||
| await $(execaOptions)`${kuboBin} config --json Gateway.HTTPHeaders.Access-Control-Allow-Methods ${JSON.stringify(['GET', 'POST', 'PUT', 'OPTIONS'])}` |
The http-server hosted scenarios seemed fine. The _redirects logic with the newer |
|
merging to fix the bug on https://inbrowser.dev |
Title
fix: ipfs-hosted redirects are not infinite
Description
Fixes #211
Summary of changes
ipfs-hostedtests in first-hit.test.ts to use the above test server, so we are no longer only getting a ?helia-sw request. This should get us 99% closer to actual functionality when hosted in environments like inbrowser.tldsrc/pages/redirects-interstitial.tsxandsrc/pages/redirect-page.tsxbut it's not actually working for some reasonNotes & open questions
I could use an extra set of eyes on the updated use of @libp2p/logger in reverse-proxy.jsproxy-server logging fixed with688594e(#215)RedirectsInterstitialbecause it's just going to be quick Flashes that aren't really visible, but on gateways where providing the assets are slow, it will be informative.Demo showing fix:
2024-04-23.at.10.20.59.-.ipfs-hosted-redirect.mp4
Change checklist